Skip to content

Commit e35b05f

Browse files
authored
fix: avoid no-invalid-regexp false positive for shadowed RegExp (#21051)
1 parent a3172b6 commit e35b05f

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

‎lib/rules/no-invalid-regexp.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ module.exports = {
5353
},
5454

5555
create(context) {
56+
const sourceCode = context.sourceCode;
5657
const [{ allowConstructorFlags }] = context.options;
5758
let allowedFlags = [];
5859

@@ -180,7 +181,8 @@ module.exports = {
180181
"CallExpression, NewExpression"(node) {
181182
if (
182183
node.callee.type !== "Identifier" ||
183-
node.callee.name !== "RegExp"
184+
node.callee.name !== "RegExp" ||
185+
!sourceCode.isGlobalReference(node.callee)
184186
) {
185187
return;
186188
}

‎tests/lib/rules/no-invalid-regexp.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,13 @@ ruleTester.run("no-invalid-regexp", rule, {
2727
"new RegExp",
2828
"new RegExp('.', 'im')",
2929
"global.RegExp('\\\\')",
30+
"function foo(RegExp) { RegExp('['); }",
31+
"function foo(RegExp) { new RegExp('['); }",
32+
"let RegExp; RegExp('.', 'z');",
33+
{
34+
code: "RegExp('[', 'z');",
35+
languageOptions: { globals: { RegExp: "off" } },
36+
},
3037
"new RegExp('.', y)",
3138
"new RegExp('.', 'y')",
3239
"new RegExp('.', 'u')",

0 commit comments

Comments
 (0)