Fix: no-unused-vars false positive (fixes #7250) (#7258)

mysticatea · nzakas · commit dffb4fa11082 · 2016-09-30T11:08:07.000-07:00
diff --git a/lib/rules/no-unused-vars.js b/lib/rules/no-unused-vars.js
@@ -428,12 +428,12 @@ module.exports = {
                 return true;
             }
 
-            // if all parameters preceded by this variable are ignored, this is the last.
+            // if all parameters preceded by this variable are ignored and unused, this is the last.
             if (config.argsIgnorePattern) {
                 const params = context.getDeclaredVariables(def.node);
                 const posteriorParams = params.slice(params.indexOf(variable) + 1);
 
-                if (posteriorParams.every(v => config.argsIgnorePattern.test(v.name))) {
+                if (posteriorParams.every(v => v.references.length === 0 && config.argsIgnorePattern.test(v.name))) {
                     return true;
                 }
             }
diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
@@ -225,6 +225,17 @@ ruleTester.run("no-unused-vars", rule, {
             options: [{argsIgnorePattern: "d"}],
             parserOptions: {ecmaVersion: 6}
         },
+
+        // https://github.com/eslint/eslint/issues/7250
+        {
+            code: "(function(a, b, c) { c })",
+            options: [{argsIgnorePattern: "c"}],
+        },
+        {
+            code: "(function(a, b, {c, d}) { c })",
+            options: [{argsIgnorePattern: "[cd]"}],
+            parserOptions: {ecmaVersion: 6},
+        },
     ],
     invalid: [
         { code: "function foox() { return foox(); }", errors: [{ message: "'foox' is defined but never used.", type: "Identifier"}] },

Original file line number	Diff line number	Diff line change
`@@ -428,12 +428,12 @@ module.exports = {`
`428`	`428`	`return true;`
`429`	`429`	`}`
`430`	`430`
`431`		`- // if all parameters preceded by this variable are ignored, this is the last.`
	`431`	`+ // if all parameters preceded by this variable are ignored and unused, this is the last.`
`432`	`432`	`if (config.argsIgnorePattern) {`
`433`	`433`	`const params = context.getDeclaredVariables(def.node);`
`434`	`434`	`const posteriorParams = params.slice(params.indexOf(variable) + 1);`
`435`	`435`
`436`		`- if (posteriorParams.every(v => config.argsIgnorePattern.test(v.name))) {`
	`436`	`+ if (posteriorParams.every(v => v.references.length === 0 && config.argsIgnorePattern.test(v.name))) {`
`437`	`437`	`return true;`
`438`	`438`	`}`
`439`	`439`	`}`