Fix: no-implied-eval false positive on 'setTimeoutFoo' (fixes #7821) (#7836)

not-an-aardvark · ilyavolodin · commit c5c3b21257f1 · 2016-12-31T19:16:47.000-05:00
diff --git a/lib/rules/no-implied-eval.js b/lib/rules/no-implied-eval.js
@@ -21,7 +21,7 @@ module.exports = {
     },
 
     create(context) {
-        const CALLEE_RE = /set(?:Timeout|Interval)|execScript/;
+        const CALLEE_RE = /^(setTimeout|setInterval|execScript)$/;
 
         /*
          * Figures out if we should inspect a given binary expression. Is a stack
diff --git a/tests/lib/rules/no-implied-eval.js b/tests/lib/rules/no-implied-eval.js
@@ -53,7 +53,10 @@ ruleTester.run("no-implied-eval", rule, {
         "setTimeout(foobar, foo + 'bar')",
 
         // only checks immediate subtrees of the argument
-        "setTimeout(function() { return 'foobar'; }, 10)"
+        "setTimeout(function() { return 'foobar'; }, 10)",
+
+        // https://github.com/eslint/eslint/issues/7821
+        "setTimeoutFooBar('Foo Bar')"
     ],
 
     invalid: [
