Skip to content

Commit a3172b6

Browse files
authored
fix: avoid no-control-regex false positive for shadowed RegExp (#21050)
1 parent 1056a99 commit a3172b6

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

‎lib/rules/no-control-regex.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ module.exports = {
8181
},
8282

8383
create(context) {
84+
const sourceCode = context.sourceCode;
85+
8486
/**
8587
* Get the regex expression
8688
* @param {ASTNode} node `Literal` node to evaluate
@@ -99,6 +101,7 @@ module.exports = {
99101
node.parent.type === "CallExpression") &&
100102
node.parent.callee.type === "Identifier" &&
101103
node.parent.callee.name === "RegExp" &&
104+
sourceCode.isGlobalReference(node.parent.callee) &&
102105
node.parent.arguments[0] === node
103106
) {
104107
const pattern = node.value;

‎tests/lib/rules/no-control-regex.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,13 @@ ruleTester.run("no-control-regex", rule, {
2626
"var regex = RegExp('x1f')",
2727
"new RegExp('[')",
2828
"RegExp('[')",
29+
String.raw`function foo(RegExp) { RegExp("\x1f"); }`,
30+
String.raw`function foo(RegExp) { new RegExp("\x1f"); }`,
31+
String.raw`let RegExp; RegExp("\x1f");`,
32+
{
33+
code: String.raw`RegExp("\x1f")`,
34+
languageOptions: { globals: { RegExp: "off" } },
35+
},
2936
"new (function foo(){})('\\x1f')",
3037
{ code: String.raw`/\u{20}/u`, languageOptions: { ecmaVersion: 2015 } },
3138
String.raw`/\u{1F}/`,

0 commit comments

Comments
 (0)