Fix: no-restricted-imports schema allows multiple paths/patterns objects (#12639)

mdjermanovic · btmills · commit a258039e5560 · 2019-12-20T15:18:40.000-05:00
diff --git a/lib/rules/no-restricted-imports.js b/lib/rules/no-restricted-imports.js
@@ -72,14 +72,14 @@ module.exports = {
                 arrayOfStringsOrObjects,
                 {
                     type: "array",
-                    items: {
+                    items: [{
                         type: "object",
                         properties: {
                             paths: arrayOfStringsOrObjects,
                             patterns: arrayOfStrings
                         },
                         additionalProperties: false
-                    },
+                    }],
                     additionalItems: false
                 }
             ]
diff --git a/tests/lib/rules/no-restricted-imports.js b/tests/lib/rules/no-restricted-imports.js
@@ -20,6 +20,7 @@ const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6, sourceType:
 
 ruleTester.run("no-restricted-imports", rule, {
     valid: [
+        "import os from \"os\";",
         { code: "import os from \"os\";", options: ["osx"] },
         { code: "import fs from \"fs\";", options: ["crypto"] },
         { code: "import path from \"path\";", options: ["crypto", "stream", "os"] },

Original file line number	Diff line number	Diff line change
`@@ -72,14 +72,14 @@ module.exports = {`
`72`	`72`	`arrayOfStringsOrObjects,`
`73`	`73`	`{`
`74`	`74`	`type: "array",`
`75`		`- items: {`
	`75`	`+ items: [{`
`76`	`76`	`type: "object",`
`77`	`77`	`properties: {`
`78`	`78`	`paths: arrayOfStringsOrObjects,`
`79`	`79`	`patterns: arrayOfStrings`
`80`	`80`	`},`
`81`	`81`	`additionalProperties: false`
`82`		`- },`
	`82`	`+ }],`
`83`	`83`	`additionalItems: false`
`84`	`84`	`}`
`85`	`85`	`]`