Skip to content

Commit 8e2cb14

Browse files
authored
fix: new-cap false positive for UTC calls with properties: false (#21275)
1 parent 2417cad commit 8e2cb14

2 files changed

Lines changed: 16 additions & 7 deletions

File tree

‎lib/rules/new-cap.js‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,15 +176,21 @@ module.exports = {
176176

177177
const callee = astUtils.skipChainExpression(node.callee);
178178

179-
if (calleeName === "UTC" && callee.type === "MemberExpression") {
180-
// allow if callee is Date.UTC
181-
return (
182-
callee.object.type === "Identifier" &&
183-
callee.object.name === "Date"
184-
);
179+
if (callee.type === "MemberExpression") {
180+
if (skipProperties) {
181+
return true;
182+
}
183+
184+
if (calleeName === "UTC") {
185+
// allow if callee is Date.UTC
186+
return (
187+
callee.object.type === "Identifier" &&
188+
callee.object.name === "Date"
189+
);
190+
}
185191
}
186192

187-
return skipProperties && callee.type === "MemberExpression";
193+
return false;
188194
}
189195

190196
/**

‎tests/lib/rules/new-cap.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ ruleTester.run("new-cap", rule, {
108108
code: "var x = foo.Bar(42);",
109109
options: [{ capIsNew: false, properties: false }],
110110
},
111+
{ code: "foo.UTC();", options: [{ properties: false }] },
112+
{ code: "foo?.UTC();", options: [{ properties: false }] },
113+
{ code: "const b = a.Date.UTC();", options: [{ properties: false }] },
111114

112115
// Optional chaining
113116
{

0 commit comments

Comments
 (0)