Skip to content

Commit 8b6f6c0

Browse files
authored
fix: apply ignore configs to computed methods in class-methods-use-this (#21094)
1 parent eccc68d commit 8b6f6c0

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

‎lib/rules/class-methods-use-this.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,6 @@ module.exports = {
141141
*/
142142
function isIncludedInstanceMethod(node) {
143143
if (isInstanceMethod(node)) {
144-
if (node.computed) {
145-
return true;
146-
}
147-
148144
if (ignoreOverrideMethods && node.override) {
149145
return false;
150146
}
@@ -164,6 +160,10 @@ module.exports = {
164160
}
165161
}
166162

163+
if (node.computed) {
164+
return true;
165+
}
166+
167167
const hashIfNeeded =
168168
node.key.type === "PrivateIdentifier" ? "#" : "";
169169
const name =

‎tests/lib/rules/class-methods-use-this.js‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,10 @@ ruleTesterTypeScript.run("class-methods-use-this", rule, {
504504
code: "class Foo { override method() {} }",
505505
options: [{ ignoreOverrideMethods: true }],
506506
},
507+
{
508+
code: 'class Foo { override ["method"]() {} }',
509+
options: [{ ignoreOverrideMethods: true }],
510+
},
507511
{
508512
code: "class Foo { private override method() {} }",
509513
options: [{ ignoreOverrideMethods: true }],
@@ -664,6 +668,10 @@ ruleTesterTypeScript.run("class-methods-use-this", rule, {
664668
code: "class Foo implements Bar { method() {} }",
665669
options: [{ ignoreClassesWithImplements: "all" }],
666670
},
671+
{
672+
code: 'class Foo implements Bar { ["method"]() {} }',
673+
options: [{ ignoreClassesWithImplements: "all" }],
674+
},
667675
{
668676
code: "class Foo implements Bar { accessor method = () => {} }",
669677
options: [{ ignoreClassesWithImplements: "all" }],
@@ -692,6 +700,10 @@ ruleTesterTypeScript.run("class-methods-use-this", rule, {
692700
code: "const Foo = class implements Bar { method() {} };",
693701
options: [{ ignoreClassesWithImplements: "public-fields" }],
694702
},
703+
{
704+
code: 'class Foo implements Bar { ["property"] = () => {} }',
705+
options: [{ ignoreClassesWithImplements: "public-fields" }],
706+
},
695707
],
696708
invalid: [
697709
{

0 commit comments

Comments
 (0)