Skip to content

Commit 8859baf

Browse files
authored
fix: avoid prefer-numeric-literals false positive for shadowed globals (#21047)
1 parent a9e5961 commit 8859baf

2 files changed

Lines changed: 20 additions & 6 deletions

File tree

‎lib/rules/prefer-numeric-literals.js‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,22 @@ const radixMap = new Map([
2525
* Checks to see if a CallExpression's callee node is `parseInt` or
2626
* `Number.parseInt`.
2727
* @param {ASTNode} calleeNode The callee node to evaluate.
28+
* @param {SourceCode} sourceCode The source code object.
2829
* @returns {boolean} True if the callee is `parseInt` or `Number.parseInt`,
2930
* false otherwise.
3031
*/
31-
function isParseInt(calleeNode) {
32-
return (
33-
astUtils.isSpecificId(calleeNode, "parseInt") ||
34-
astUtils.isSpecificMemberAccess(calleeNode, "Number", "parseInt")
35-
);
32+
function isParseInt(calleeNode, sourceCode) {
33+
if (astUtils.isSpecificId(calleeNode, "parseInt")) {
34+
return sourceCode.isGlobalReference(calleeNode);
35+
}
36+
37+
if (astUtils.isSpecificMemberAccess(calleeNode, "Number", "parseInt")) {
38+
const objectNode = astUtils.skipChainExpression(calleeNode).object;
39+
40+
return sourceCode.isGlobalReference(objectNode);
41+
}
42+
43+
return false;
3644
}
3745

3846
//------------------------------------------------------------------------------
@@ -81,7 +89,7 @@ module.exports = {
8189
radixNode.type === "Literal" &&
8290
typeof radix === "number" &&
8391
radixMap.has(radix) &&
84-
isParseInt(node.callee)
92+
isParseInt(node.callee, sourceCode)
8593
) {
8694
const { system, literalPrefix } = radixMap.get(radix);
8795

‎tests/lib/rules/prefer-numeric-literals.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ ruleTester.run("prefer-numeric-literals", rule, {
6363
code: 'class C { #parseInt; foo() { Number.#parseInt("111110111", 2); } }',
6464
languageOptions: { ecmaVersion: 2022 },
6565
},
66+
67+
// Shadowed `parseInt` and `Number` should not be reported.
68+
'function foo(parseInt) { parseInt("111110111", 2); }',
69+
'function foo() { var parseInt; parseInt("111110111", 2); }',
70+
'function foo(Number) { Number.parseInt("111110111", 2); }',
71+
'function foo() { var Number; Number.parseInt("111110111", 2); }',
6672
],
6773
invalid: [
6874
{

0 commit comments

Comments
 (0)