test: ensure tmp directory cleanup in check-emfile-handling.js (#19036)

LiviaMedeiros · web-flow · commit 725962731538 · 2024-10-21T16:00:33.000+02:00
* test: ensure tmp directory cleanup in `check-emfile-handling.js`

* increase `maxRetries`

* increase `maxRetries` further

* add delay

* use `Promise.allSettled` to ensure all `readFile`s are settled
diff --git a/tools/check-emfile-handling.js b/tools/check-emfile-handling.js
@@ -56,6 +56,7 @@ if (os.platform() !== "win32") {
  */
 function generateFiles() {
 
+    fs.rmSync(OUTPUT_DIRECTORY, { recursive: true, force: true, maxRetries: 8 });
     fs.mkdirSync(OUTPUT_DIRECTORY, { recursive: true });
 
     for (let i = 0; i < FILE_COUNT; i++) {
@@ -69,16 +70,21 @@ function generateFiles() {
 
 /**
  * Generates an EMFILE error by reading all files in the output directory.
- * @returns {Promise<Buffer[]>} A promise that resolves with the contents of all files.
+ * @returns {undefined}
  */
-function generateEmFileError() {
-    return Promise.all(
+async function generateEmFileError() {
+    const results = await Promise.allSettled(
         Array.from({ length: FILE_COUNT }, (_, i) => {
             const fileName = `file_${i}.js`;
 
             return readFile(`${OUTPUT_DIRECTORY}/${fileName}`);
         })
     );
+    const failedResult = results.find(({ status }) => status === "rejected");
+
+    if (failedResult?.reason) {
+        throw failedResult.reason;
+    }
 }
 
 //------------------------------------------------------------------------------
@@ -106,4 +112,7 @@ generateEmFileError()
             console.error("❌ Unexpected error encountered:", error.message);
             throw error;
         }
+    })
+    .finally(() => {
+        fs.rmSync(OUTPUT_DIRECTORY, { recursive: true, force: true, maxRetries: 8 });
     });
