fix: fix crash when message.fix is nullish (#19168)

ntnyq · web-flow · commit 67d683df29d8 · 2024-12-09T07:41:20.000+01:00
* fix: fix crash when `message.fix` is nil

* chore: teak test case title

* chore: update test cases
diff --git a/lib/linter/source-code-fixer.js b/lib/linter/source-code-fixer.js
@@ -107,7 +107,7 @@ SourceCodeFixer.applyFixes = function(sourceText, messages, shouldFix) {
     }
 
     messages.forEach(problem => {
-        if (Object.hasOwn(problem, "fix")) {
+        if (Object.hasOwn(problem, "fix") && problem.fix) {
             fixes.push(problem);
         } else {
             remainingMessages.push(problem);
diff --git a/tests/lib/linter/source-code-fixer.js b/tests/lib/linter/source-code-fixer.js
@@ -127,6 +127,14 @@ const INSERT_AT_END = {
             range: [3, 0],
             text: " "
         }
+    },
+    UNDEFINED_FIX = {
+        message: "undefined",
+        fix: void 0
+    },
+    NULL_FIX = {
+        message: "null",
+        fix: null
     };
 
 //------------------------------------------------------------------------------
@@ -421,6 +429,26 @@ describe("SourceCodeFixer", () => {
 
         });
 
+        describe("Nullish fixes", () => {
+            it("should not throw if fix is null", () => {
+                const result = SourceCodeFixer.applyFixes(TEST_CODE, [NULL_FIX]);
+
+                assert.isFalse(result.fixed);
+                assert.strictEqual(result.output, TEST_CODE);
+                assert.strictEqual(result.messages.length, 1);
+                assert.strictEqual(result.messages[0].message, "null");
+            });
+
+            it("should not throw if fix is undefined", () => {
+                const result = SourceCodeFixer.applyFixes(TEST_CODE, [UNDEFINED_FIX]);
+
+                assert.isFalse(result.fixed);
+                assert.strictEqual(result.output, TEST_CODE);
+                assert.strictEqual(result.messages.length, 1);
+                assert.strictEqual(result.messages[0].message, "undefined");
+            });
+        });
+
     });
 
     /*

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ SourceCodeFixer.applyFixes = function(sourceText, messages, shouldFix) {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`messages.forEach(problem => {`
`110`		`- if (Object.hasOwn(problem, "fix")) {`
	`110`	`+ if (Object.hasOwn(problem, "fix") && problem.fix) {`
`111`	`111`	`fixes.push(problem);`
`112`	`112`	`} else {`
`113`	`113`	`remainingMessages.push(problem);`