Chore: do not dynamically generating messageId

aladdin-add · aladdin-add · commit 66ab4082266c · 2018-12-26T01:51:25.000+08:00
diff --git a/lib/rules/yield-star-spacing.js b/lib/rules/yield-star-spacing.js
@@ -76,8 +76,13 @@ module.exports = {
                 const after = leftToken.value === "*";
                 const spaceRequired = mode[side];
                 const node = after ? leftToken : rightToken;
-                const type = spaceRequired ? "missing" : "unexpected";
-                const messageId = `${type}${side[0].toUpperCase()}${side.slice(1)}`;
+                let messageId = "";
+
+                if (spaceRequired) {
+                    messageId = side === "before" ? "missingBefore" : "missingAfter";
+                } else {
+                    messageId = side === "before" ? "unexpectedBefore" : "unexpectedAfter";
+                }
 
                 context.report({
                     node,
