Skip to content

Commit 5b68d51

Browse files
mdjermanovicmdjermanovic
authored
chore: Fix fixedsize attribute in code path analysis DOT debug output (#17202)
1 parent b8448ff commit 5b68d51

8 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎lib/linter/code-path-analysis/debug-helpers.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ module.exports = {
109109
text += "final[label=\"\",shape=doublecircle,style=filled,fillcolor=black,width=0.25,height=0.25];\n";
110110
}
111111
if (codePath.thrownSegments.length > 0) {
112-
text += "thrown[label=\"✘\",shape=circle,width=0.3,height=0.3,fixedsize];\n";
112+
text += "thrown[label=\"✘\",shape=circle,width=0.3,height=0.3,fixedsize=true];\n";
113113
}
114114

115115
const traceMap = Object.create(null);

‎tests/fixtures/code-path-analysis/if-4.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ digraph {
1616
node[shape=box,style="rounded,filled",fillcolor=white];
1717
initial[label="",shape=circle,style=filled,fillcolor=black,width=0.25,height=0.25];
1818
final[label="",shape=doublecircle,style=filled,fillcolor=black,width=0.25,height=0.25];
19-
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize];
19+
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize=true];
2020
s1_1[label="Program\nIfStatement\nIdentifier (a)"];
2121
s1_2[label="BlockStatement\nReturnStatement\nLiteral (0)"];
2222
s1_3[label="BlockStatement:exit"];

‎tests/fixtures/code-path-analysis/try--try-catch-2.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ digraph {
1616
node[shape=box,style="rounded,filled",fillcolor=white];
1717
initial[label="",shape=circle,style=filled,fillcolor=black,width=0.25,height=0.25];
1818
final[label="",shape=doublecircle,style=filled,fillcolor=black,width=0.25,height=0.25];
19-
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize];
19+
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize=true];
2020
s1_1[label="Program\nTryStatement\nBlockStatement\nExpressionStatement\nCallExpression\nIdentifier (foo)"];
2121
s1_2[label="CallExpression:exit\nExpressionStatement:exit\nBlockStatement:exit"];
2222
s1_3[label="CatchClause\nIdentifier (err)\nBlockStatement\nThrowStatement\nIdentifier (err)"];

‎tests/fixtures/code-path-analysis/try--try-catch-4.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ digraph {
2929
node[shape=box,style="rounded,filled",fillcolor=white];
3030
initial[label="",shape=circle,style=filled,fillcolor=black,width=0.25,height=0.25];
3131
final[label="",shape=doublecircle,style=filled,fillcolor=black,width=0.25,height=0.25];
32-
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize];
32+
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize=true];
3333
s1_1[label="Program\nTryStatement\nBlockStatement\nTryStatement\nBlockStatement\nIfStatement\nIdentifier (a)"];
3434
s1_3[label="BlockStatement\nThrowStatement\nIdentifier (err)"];
3535
s1_4[style="rounded,dashed,filled",fillcolor="#FF9800",label="<<unreachable>>\nBlockStatement:exit"];

‎tests/fixtures/code-path-analysis/try--try-finally-1.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ digraph {
1919
node[shape=box,style="rounded,filled",fillcolor=white];
2020
initial[label="",shape=circle,style=filled,fillcolor=black,width=0.25,height=0.25];
2121
final[label="",shape=doublecircle,style=filled,fillcolor=black,width=0.25,height=0.25];
22-
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize];
22+
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize=true];
2323
s1_1[label="Program\nTryStatement\nBlockStatement\nExpressionStatement\nCallExpression\nIdentifier (foo)"];
2424
s1_2[label="CallExpression:exit\nExpressionStatement:exit\nBlockStatement:exit"];
2525
s1_3[label="BlockStatement\nExpressionStatement\nCallExpression\nIdentifier (bar)\nExpressionStatement\nCallExpression\nIdentifier (last)"];

‎tests/fixtures/code-path-analysis/try--try-finally-3.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ last();
1717
digraph {
1818
node[shape=box,style="rounded,filled",fillcolor=white];
1919
initial[label="",shape=circle,style=filled,fillcolor=black,width=0.25,height=0.25];
20-
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize];
20+
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize=true];
2121
s1_1[label="Program\nTryStatement\nBlockStatement\nThrowStatement\nIdentifier (err)"];
2222
s1_2[label="ThrowStatement:exit"];
2323
s1_3[style="rounded,dashed,filled",fillcolor="#FF9800",label="<<unreachable>>\nBlockStatement:exit"];

‎tests/fixtures/code-path-analysis/try--try-finally-4.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ digraph {
3232
node[shape=box,style="rounded,filled",fillcolor=white];
3333
initial[label="",shape=circle,style=filled,fillcolor=black,width=0.25,height=0.25];
3434
final[label="",shape=doublecircle,style=filled,fillcolor=black,width=0.25,height=0.25];
35-
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize];
35+
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize=true];
3636
s1_1[label="Program\nTryStatement\nBlockStatement\nTryStatement\nBlockStatement\nIfStatement\nIdentifier (a)"];
3737
s1_3[label="BlockStatement\nReturnStatement"];
3838
s1_4[style="rounded,dashed,filled",fillcolor="#FF9800",label="<<unreachable>>\nBlockStatement:exit"];

‎tests/fixtures/code-path-analysis/try--try-finally-5.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ digraph {
3131
node[shape=box,style="rounded,filled",fillcolor=white];
3232
initial[label="",shape=circle,style=filled,fillcolor=black,width=0.25,height=0.25];
3333
final[label="",shape=doublecircle,style=filled,fillcolor=black,width=0.25,height=0.25];
34-
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize];
34+
thrown[label="✘",shape=circle,width=0.3,height=0.3,fixedsize=true];
3535
s1_1[label="Program\nTryStatement\nBlockStatement\nTryStatement\nBlockStatement\nIfStatement\nIdentifier (a)"];
3636
s1_3[label="BlockStatement\nReturnStatement"];
3737
s1_4[style="rounded,dashed,filled",fillcolor="#FF9800",label="<<unreachable>>\nBlockStatement:exit"];

0 commit comments

Comments
 (0)