Skip to content

Commit 557fde8

Browse files
authored
feat: support computed Number.parseInt member access in radix rule (#21041)
1 parent 8a240a7 commit 557fde8

2 files changed

Lines changed: 80 additions & 16 deletions

File tree

‎lib/rules/radix.js‎

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,6 @@ function isShadowed(variable) {
3434
return variable.defs.length >= 1;
3535
}
3636

37-
/**
38-
* Checks whether a given node is a MemberExpression of `parseInt` method or not.
39-
* @param {ASTNode} node A node to check.
40-
* @returns {boolean} `true` if the node is a MemberExpression of `parseInt`
41-
* method.
42-
*/
43-
function isParseIntMethod(node) {
44-
return (
45-
node.type === "MemberExpression" &&
46-
!node.computed &&
47-
node.property.type === "Identifier" &&
48-
node.property.name === "parseInt"
49-
);
50-
}
51-
5237
/**
5338
* Checks whether a given node is a valid value of radix or not.
5439
*
@@ -201,7 +186,11 @@ module.exports = {
201186
: parentNode;
202187

203188
if (
204-
isParseIntMethod(parentNode) &&
189+
astUtils.isSpecificMemberAccess(
190+
parentNode,
191+
"Number",
192+
"parseInt",
193+
) &&
205194
astUtils.isCallee(maybeCallee)
206195
) {
207196
checkArguments(maybeCallee.parent);

‎tests/lib/rules/radix.js‎

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ ruleTester.run("radix", rule, {
3636
'parseInt("10", foo);',
3737
'function foo(undefined) { parseInt("10", undefined); }',
3838
'Number.parseInt("10", foo);',
39+
'Number["parseInt"]("10", foo);',
40+
'Number[`parseInt`]("10", 10);',
3941
'Number.parseInt("10", +10);',
4042
'Number.parseInt("10", +"10");',
4143
'Number.parseInt("10", ~1);',
@@ -68,6 +70,7 @@ ruleTester.run("radix", rule, {
6870
// Ignores if it's shadowed or disabled.
6971
"var parseInt; parseInt();",
7072
"var Number; Number.parseInt();",
73+
"let Number; Number['parseInt']();",
7174
"/* globals parseInt:off */ parseInt(foo);",
7275
{
7376
code: "Number.parseInt(foo);",
@@ -326,6 +329,50 @@ ruleTester.run("radix", rule, {
326329
},
327330
],
328331
},
332+
{
333+
code: 'Number["parseInt"]();',
334+
errors: [
335+
{
336+
messageId: "missingParameters",
337+
},
338+
],
339+
},
340+
{
341+
code: 'Number["parseInt"]("10");',
342+
errors: [
343+
{
344+
messageId: "missingRadix",
345+
suggestions: [
346+
{
347+
messageId: "addRadixParameter10",
348+
output: 'Number["parseInt"]("10", 10);',
349+
},
350+
],
351+
},
352+
],
353+
},
354+
{
355+
code: "Number['parseInt']('10', 1);",
356+
errors: [
357+
{
358+
messageId: "invalidRadix",
359+
},
360+
],
361+
},
362+
{
363+
code: 'Number[`parseInt`]("10");',
364+
errors: [
365+
{
366+
messageId: "missingRadix",
367+
suggestions: [
368+
{
369+
messageId: "addRadixParameter10",
370+
output: 'Number[`parseInt`]("10", 10);',
371+
},
372+
],
373+
},
374+
],
375+
},
329376
{
330377
code: 'Number.parseInt("10", 1, ...args);',
331378
errors: [
@@ -396,6 +443,34 @@ ruleTester.run("radix", rule, {
396443
},
397444
],
398445
},
446+
{
447+
code: 'Number?.["parseInt"]("10");',
448+
errors: [
449+
{
450+
messageId: "missingRadix",
451+
suggestions: [
452+
{
453+
messageId: "addRadixParameter10",
454+
output: 'Number?.["parseInt"]("10", 10);',
455+
},
456+
],
457+
},
458+
],
459+
},
460+
{
461+
code: 'Number["parseInt"]?.("10");',
462+
errors: [
463+
{
464+
messageId: "missingRadix",
465+
suggestions: [
466+
{
467+
messageId: "addRadixParameter10",
468+
output: 'Number["parseInt"]?.("10", 10);',
469+
},
470+
],
471+
},
472+
],
473+
},
399474

400475
// Deprecated options "always" and "as-needed" should work the same as the default behavior of this rule
401476
{

0 commit comments

Comments
 (0)