Skip to content

Commit 51f9620

Browse files
mdjermanovicbtmills
authored andcommitted
Fix: improve report location for array-bracket-spacing (#12653)
1 parent 45364af commit 51f9620

2 files changed

Lines changed: 301 additions & 58 deletions

File tree

lib/rules/array-bracket-spacing.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,16 @@ module.exports = {
8484
* @returns {void}
8585
*/
8686
function reportNoBeginningSpace(node, token) {
87+
const nextToken = sourceCode.getTokenAfter(token);
88+
8789
context.report({
8890
node,
89-
loc: token.loc.start,
91+
loc: { start: token.loc.end, end: nextToken.loc.start },
9092
messageId: "unexpectedSpaceAfter",
9193
data: {
9294
tokenValue: token.value
9395
},
9496
fix(fixer) {
95-
const nextToken = sourceCode.getTokenAfter(token);
96-
9797
return fixer.removeRange([token.range[1], nextToken.range[0]]);
9898
}
9999
});
@@ -106,16 +106,16 @@ module.exports = {
106106
* @returns {void}
107107
*/
108108
function reportNoEndingSpace(node, token) {
109+
const previousToken = sourceCode.getTokenBefore(token);
110+
109111
context.report({
110112
node,
111-
loc: token.loc.start,
113+
loc: { start: previousToken.loc.end, end: token.loc.start },
112114
messageId: "unexpectedSpaceBefore",
113115
data: {
114116
tokenValue: token.value
115117
},
116118
fix(fixer) {
117-
const previousToken = sourceCode.getTokenBefore(token);
118-
119119
return fixer.removeRange([previousToken.range[1], token.range[0]]);
120120
}
121121
});
@@ -130,7 +130,7 @@ module.exports = {
130130
function reportRequiredBeginningSpace(node, token) {
131131
context.report({
132132
node,
133-
loc: token.loc.start,
133+
loc: token.loc,
134134
messageId: "missingSpaceAfter",
135135
data: {
136136
tokenValue: token.value
@@ -150,7 +150,7 @@ module.exports = {
150150
function reportRequiredEndingSpace(node, token) {
151151
context.report({
152152
node,
153-
loc: token.loc.start,
153+
loc: token.loc,
154154
messageId: "missingSpaceBefore",
155155
data: {
156156
tokenValue: token.value

0 commit comments

Comments
 (0)