feat: limit the name given to ImportSpecifier in id-length (#18861)

Tanujkanti4441 · web-flow · commit 492eb8f34ebb · 2024-09-16T10:26:14.000-04:00
* feat: report name given to ImportSpecifier

* update code

* no error on same local name

* add more tests
diff --git a/lib/rules/id-length.js b/lib/rules/id-length.js
@@ -11,6 +11,7 @@
 //------------------------------------------------------------------------------
 
 const { getGraphemeCount } = require("../shared/string-utils");
+const { getModuleExportName } = require("./utils/ast-utils");
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -116,6 +117,12 @@ module.exports = {
                 }
                 return properties && !parent.computed && parent.key.name === node.name;
             },
+            ImportSpecifier(parent, node) {
+                return (
+                    parent.local === node &&
+                    getModuleExportName(parent.imported) !== getModuleExportName(parent.local)
+                );
+            },
             ImportDefaultSpecifier: true,
             ImportNamespaceSpecifier: true,
             RestElement: true,
diff --git a/tests/lib/rules/id-length.js b/tests/lib/rules/id-length.js
@@ -66,7 +66,11 @@ ruleTester.run("id-length", rule, {
         { code: "export var num = 0;", languageOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "import * as something from 'y';", languageOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "import { x } from 'y';", languageOptions: { ecmaVersion: 6, sourceType: "module" } },
+        { code: "import { x as x } from 'y';", languageOptions: { ecmaVersion: 6, sourceType: "module" } },
+        { code: "import { 'x' as x } from 'y';", languageOptions: { ecmaVersion: 2022, sourceType: "module" } },
+        { code: "import { x as foo } from 'y';", languageOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "import { longName } from 'y';", options: [{ max: 5 }], languageOptions: { ecmaVersion: 6, sourceType: "module" } },
+        { code: "import { x as bar } from 'y';", options: [{ max: 5 }], languageOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "({ prop: obj.x.y.something } = {});", languageOptions: { ecmaVersion: 6 } },
         { code: "({ prop: obj.longName } = {});", languageOptions: { ecmaVersion: 6 } },
         { code: "var obj = { a: 1, bc: 2 };", options: [{ properties: "never" }] },
@@ -250,6 +254,9 @@ ruleTester.run("id-length", rule, {
         { code: "var [,i,a] = arr;", languageOptions: { ecmaVersion: 6 }, errors: [tooShortError, tooShortError] },
         { code: "function foo([a]) {}", languageOptions: { ecmaVersion: 6 }, errors: [tooShortError] },
         { code: "import x from 'module';", languageOptions: { ecmaVersion: 6 }, errors: [tooShortError] },
+        { code: "import { x as z } from 'module';", languageOptions: { ecmaVersion: 6 }, errors: [{ ...tooShortError, column: 15 }] },
+        { code: "import { foo as z } from 'module';", languageOptions: { ecmaVersion: 6 }, errors: [{ ...tooShortError, column: 17 }] },
+        { code: "import { 'foo' as z } from 'module';", languageOptions: { ecmaVersion: 2022 }, errors: [{ ...tooShortError, column: 19 }] },
         { code: "import * as x from 'module';", languageOptions: { ecmaVersion: 6 }, errors: [tooShortError] },
         {
             code: "import longName from 'module';",
@@ -263,6 +270,12 @@ ruleTester.run("id-length", rule, {
             languageOptions: { ecmaVersion: 6 },
             errors: [tooLongError]
         },
+        {
+            code: "import { foo as longName } from 'module';",
+            options: [{ max: 5 }],
+            languageOptions: { ecmaVersion: 6 },
+            errors: [{ ...tooLongError, column: 17 }]
+        },
         {
             code: "var _$xt_$ = Foo(42)",
             options: [{ min: 2, max: 4 }],
