Update: Ensure indent handles nested functions correctly (fixes #7249) (#7265)

not-an-aardvark · nzakas · commit 332d21383d58 · 2016-09-30T11:05:45.000-07:00
diff --git a/lib/rules/indent.js b/lib/rules/indent.js
@@ -939,7 +939,7 @@ module.exports = {
                 if (options.FunctionDeclaration.parameters === "first" && node.params.length) {
                     checkNodesIndent(node.params.slice(1), node.params[0].loc.start.column);
                 } else if (options.FunctionDeclaration.parameters !== null) {
-                    checkNodesIndent(node.params, indentSize * options.FunctionDeclaration.parameters);
+                    checkNodesIndent(node.params, getNodeIndent(node).goodChar + indentSize * options.FunctionDeclaration.parameters);
                 }
             },
 
@@ -950,7 +950,7 @@ module.exports = {
                 if (options.FunctionExpression.parameters === "first" && node.params.length) {
                     checkNodesIndent(node.params.slice(1), node.params[0].loc.start.column);
                 } else if (options.FunctionExpression.parameters !== null) {
-                    checkNodesIndent(node.params, indentSize * options.FunctionExpression.parameters);
+                    checkNodesIndent(node.params, getNodeIndent(node).goodChar + indentSize * options.FunctionExpression.parameters);
                 }
             }
         };
diff --git a/tests/lib/rules/indent.js b/tests/lib/rules/indent.js
@@ -1561,13 +1561,42 @@ ruleTester.run("indent", rule, {
             "}",
             options: [2]
         },
+        {
+            code:
+            "function foo() {\n" +
+            "  function bar() {\n" +
+            "    baz();\n" +
+            "  }\n" +
+            "}",
+            options: [2, {FunctionDeclaration: {body: 1}}]
+        },
         {
             code:
             "function foo() {\n" +
             "  bar();\n" +
             "   \t\t}",
             options: [2]
         },
+        {
+            code:
+            "function foo() {\n" +
+            "  function bar(baz,\n" +
+            "      qux) {\n" +
+            "    foobar();\n" +
+            "  }\n" +
+            "}",
+            options: [2, {FunctionDeclaration: {body: 1, parameters: 2}}]
+        },
+        {
+            code:
+            "function foo() {\n" +
+            "  var bar = function(baz,\n" +
+            "        qux) {\n" +
+            "    foobar();\n" +
+            "  };\n" +
+            "}",
+            options: [2, {FunctionExpression: {parameters: 3}}]
+        }
     ],
     invalid: [
         {
@@ -2878,6 +2907,70 @@ ruleTester.run("indent", rule, {
             "}",
             options: ["tab"],
             errors: expectedErrors("tab", [[3, "1 tab", "2 spaces", "ExpressionStatement"], [4, "1 tab", "14 spaces", "ExpressionStatement"]])
+        },
+        {
+            code:
+            "function foo() {\n" +
+            "  bar();\n" +
+            "\t\t}",
+            output:
+            "function foo() {\n" +
+            "  bar();\n" +
+            "}",
+            options: [2],
+            errors: expectedErrors([[3, "0 spaces", "2 tabs", "BlockStatement"]])
+        },
+        {
+            code:
+            "function foo() {\n" +
+            "  function bar() {\n" +
+            "        baz();\n" +
+            "  }\n" +
+            "}",
+            output:
+            "function foo() {\n" +
+            "  function bar() {\n" +
+            "    baz();\n" +
+            "  }\n" +
+            "}",
+            options: [2, {FunctionDeclaration: {body: 1}}],
+            errors: expectedErrors([3, 4, 8, "ExpressionStatement"])
+        },
+        {
+            code:
+            "function foo() {\n" +
+            "  function bar(baz,\n" +
+            "    qux) {\n" +
+            "    foobar();\n" +
+            "  }\n" +
+            "}",
+            output:
+            "function foo() {\n" +
+            "  function bar(baz,\n" +
+            "      qux) {\n" +
+            "    foobar();\n" +
+            "  }\n" +
+            "}",
+            options: [2, {FunctionDeclaration: {body: 1, parameters: 2}}],
+            errors: expectedErrors([3, 6, 4, "Identifier"])
+        },
+        {
+            code:
+            "function foo() {\n" +
+            "  var bar = function(baz,\n" +
+            "          qux) {\n" +
+            "    foobar();\n" +
+            "  };\n" +
+            "}",
+            output:
+            "function foo() {\n" +
+            "  var bar = function(baz,\n" +
+            "        qux) {\n" +
+            "    foobar();\n" +
+            "  };\n" +
+            "}",
+            options: [2, {FunctionExpression: {parameters: 3}}],
+            errors: expectedErrors([3, 8, 10, "Identifier"])
         }
     ]
 });

Original file line number	Diff line number	Diff line change
`@@ -939,7 +939,7 @@ module.exports = {`
`939`	`939`	`if (options.FunctionDeclaration.parameters === "first" && node.params.length) {`
`940`	`940`	`checkNodesIndent(node.params.slice(1), node.params[0].loc.start.column);`
`941`	`941`	`} else if (options.FunctionDeclaration.parameters !== null) {`
`942`		`- checkNodesIndent(node.params, indentSize * options.FunctionDeclaration.parameters);`
	`942`	`+ checkNodesIndent(node.params, getNodeIndent(node).goodChar + indentSize * options.FunctionDeclaration.parameters);`
`943`	`943`	`}`
`944`	`944`	`},`
`945`	`945`
`@@ -950,7 +950,7 @@ module.exports = {`
`950`	`950`	`if (options.FunctionExpression.parameters === "first" && node.params.length) {`
`951`	`951`	`checkNodesIndent(node.params.slice(1), node.params[0].loc.start.column);`
`952`	`952`	`} else if (options.FunctionExpression.parameters !== null) {`
`953`		`- checkNodesIndent(node.params, indentSize * options.FunctionExpression.parameters);`
	`953`	`+ checkNodesIndent(node.params, getNodeIndent(node).goodChar + indentSize * options.FunctionExpression.parameters);`
`954`	`954`	`}`
`955`	`955`	`}`
`956`	`956`	`};`