Update: add fixer for lines-around-directive (#7217)

not-an-aardvark · kaicataldo · commit 18376cf75d01 · 2016-09-30T00:05:32.000-04:00
diff --git a/docs/rules/lines-around-directive.md b/docs/rules/lines-around-directive.md
@@ -1,5 +1,7 @@
 # require or disallow newlines around directives (lines-around-directive)
 
+(fixable) The `--fix` option on the [command line](../user-guide/command-line-interface#fix) automatically fixes problems reported by this rule.
+
 Directives are used in JavaScript to indicate to the execution environment that a script would like to opt into a feature such as `"strict mode"`. Directives are grouped together in a [directive prologue](http://www.ecma-international.org/ecma-262/7.0/#directive-prologue) at the top of either a file or function block and are applied to the scope in which they occur.
 
 ```js
diff --git a/lib/rules/lines-around-directive.js b/lib/rules/lines-around-directive.js
@@ -37,7 +37,8 @@ module.exports = {
                     minProperties: 2
                 }
             ]
-        }]
+        }],
+        fixable: "whitespace"
     },
 
     create(context) {
@@ -88,6 +89,12 @@ module.exports = {
                     expected: expected ? "Expected" : "Unexpected",
                     value: node.expression.value,
                     location
+                },
+                fix(fixer) {
+                    if (expected) {
+                        return location === "before" ? fixer.insertTextBefore(node, "\n") : fixer.insertTextAfter(node, "\n");
+                    }
+                    return fixer.removeRange(location === "before" ? [node.range[0] - 1, node.range[0]] : [node.range[1], node.range[1] + 1]);
                 }
             });
         }
diff --git a/tests/lib/rules/lines-around-directive.js b/tests/lib/rules/lines-around-directive.js

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,8 @@ module.exports = {`
`37`	`37`	`minProperties: 2`
`38`	`38`	`}`
`39`	`39`	`]`
`40`		`- }]`
	`40`	`+ }],`
	`41`	`+ fixable: "whitespace"`
`41`	`42`	`},`
`42`	`43`
`43`	`44`	`create(context) {`
`@@ -88,6 +89,12 @@ module.exports = {`
`88`	`89`	`expected: expected ? "Expected" : "Unexpected",`
`89`	`90`	`value: node.expression.value,`
`90`	`91`	`location`
	`92`	`+ },`
	`93`	`+ fix(fixer) {`
	`94`	`+ if (expected) {`
	`95`	`+ return location === "before" ? fixer.insertTextBefore(node, "\n") : fixer.insertTextAfter(node, "\n");`
	`96`	`+ }`
	`97`	`+ return fixer.removeRange(location === "before" ? [node.range[0] - 1, node.range[0]] : [node.range[1], node.range[1] + 1]);`
`91`	`98`	`}`
`92`	`99`	`});`
`93`	`100`	`}`