Update: improve report location in arrow-body-style (refs #12334) (#13424)

yeonjuan · web-flow · commit 0655f66525d1 · 2020-06-25T14:26:29.000-04:00
diff --git a/lib/rules/arrow-body-style.js b/lib/rules/arrow-body-style.js
@@ -136,7 +136,7 @@ module.exports = {
 
                     context.report({
                         node,
-                        loc: arrowBody.loc.start,
+                        loc: arrowBody.loc,
                         messageId,
                         fix(fixer) {
                             const fixes = [];
@@ -201,7 +201,7 @@ module.exports = {
                 if (always || (asNeeded && requireReturnForObjectLiteral && arrowBody.type === "ObjectExpression")) {
                     context.report({
                         node,
-                        loc: arrowBody.loc.start,
+                        loc: arrowBody.loc,
                         messageId: "expectedBlock",
                         fix(fixer) {
                             const fixes = [];
diff --git a/tests/lib/rules/arrow-body-style.js b/tests/lib/rules/arrow-body-style.js
@@ -53,6 +53,8 @@ ruleTester.run("arrow-body-style", rule, {
                 {
                     line: 1,
                     column: 17,
+                    endLine: 1,
+                    endColumn: 18,
                     type: "ArrowFunctionExpression",
                     messageId: "expectedBlock"
                 }
@@ -440,6 +442,8 @@ ruleTester.run("arrow-body-style", rule, {
                 {
                     line: 1,
                     column: 17,
+                    endLine: 3,
+                    endColumn: 2,
                     type: "ArrowFunctionExpression",
                     messageId: "unexpectedSingleBlock"
                 }
@@ -452,6 +456,8 @@ ruleTester.run("arrow-body-style", rule, {
                 {
                     line: 1,
                     column: 17,
+                    endLine: 2,
+                    endColumn: 13,
                     type: "ArrowFunctionExpression",
                     messageId: "unexpectedSingleBlock"
                 }
@@ -464,6 +470,8 @@ ruleTester.run("arrow-body-style", rule, {
                 {
                     line: 1,
                     column: 17,
+                    endLine: 2,
+                    endColumn: 2,
                     type: "ArrowFunctionExpression",
                     messageId: "unexpectedSingleBlock"
                 }
@@ -508,6 +516,8 @@ ruleTester.run("arrow-body-style", rule, {
                 {
                     line: 2,
                     column: 31,
+                    endLine: 7,
+                    endColumn: 16,
                     type: "ArrowFunctionExpression",
                     messageId: "unexpectedObjectBlock"
                 }

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,8 @@ ruleTester.run("arrow-body-style", rule, {`
`53`	`53`	`{`
`54`	`54`	`line: 1,`
`55`	`55`	`column: 17,`
	`56`	`+ endLine: 1,`
	`57`	`+ endColumn: 18,`
`56`	`58`	`type: "ArrowFunctionExpression",`
`57`	`59`	`messageId: "expectedBlock"`
`58`	`60`	`}`
`@@ -440,6 +442,8 @@ ruleTester.run("arrow-body-style", rule, {`
`440`	`442`	`{`
`441`	`443`	`line: 1,`
`442`	`444`	`column: 17,`
	`445`	`+ endLine: 3,`
	`446`	`+ endColumn: 2,`
`443`	`447`	`type: "ArrowFunctionExpression",`
`444`	`448`	`messageId: "unexpectedSingleBlock"`
`445`	`449`	`}`
`@@ -452,6 +456,8 @@ ruleTester.run("arrow-body-style", rule, {`
`452`	`456`	`{`
`453`	`457`	`line: 1,`
`454`	`458`	`column: 17,`
	`459`	`+ endLine: 2,`
	`460`	`+ endColumn: 13,`
`455`	`461`	`type: "ArrowFunctionExpression",`
`456`	`462`	`messageId: "unexpectedSingleBlock"`
`457`	`463`	`}`
`@@ -464,6 +470,8 @@ ruleTester.run("arrow-body-style", rule, {`
`464`	`470`	`{`
`465`	`471`	`line: 1,`
`466`	`472`	`column: 17,`
	`473`	`+ endLine: 2,`
	`474`	`+ endColumn: 2,`
`467`	`475`	`type: "ArrowFunctionExpression",`
`468`	`476`	`messageId: "unexpectedSingleBlock"`
`469`	`477`	`}`
`@@ -508,6 +516,8 @@ ruleTester.run("arrow-body-style", rule, {`
`508`	`516`	`{`
`509`	`517`	`line: 2,`
`510`	`518`	`column: 31,`
	`519`	`+ endLine: 7,`
	`520`	`+ endColumn: 16,`
`511`	`521`	`type: "ArrowFunctionExpression",`
`512`	`522`	`messageId: "unexpectedObjectBlock"`
`513`	`523`	`}`