Skip to content

Comments

[bonopark] Added Madrid's BiciMAD network#166

Merged
eskerda merged 1 commit intoeskerda:masterfrom
bcaller:bcaller-bicimad
Jul 9, 2016
Merged

[bonopark] Added Madrid's BiciMAD network#166
eskerda merged 1 commit intoeskerda:masterfrom
bcaller:bcaller-bicimad

Conversation

@bcaller
Copy link
Contributor

@bcaller bcaller commented Jul 7, 2016

The bike network for Madrid, Spain.

@bcaller bcaller changed the title Added Madrid's BiciMAD network [bonopark] Added Madrid's BiciMAD network Jul 7, 2016
def update(self, scraper=None):
if scraper is None:
scraper = utils.PyBikesScraper()
scraper.headers['Content-Type'] = 'application/json'
Copy link
Owner

@eskerda eskerda Jul 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set this user agent Apache-HttpClient/UNAVAILABLE (java 1.4)? Seems to be the one the app is using.

That can be done either by setting the header, or by using scraper.setUserAgent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be the correct user agent, though for now it works without.

@bcaller bcaller force-pushed the bcaller-bicimad branch from f4c5ccb to 60d922a Compare July 9, 2016 17:58
@bcaller
Copy link
Contributor Author

bcaller commented Jul 9, 2016

I have added the user agent.

@eskerda
Copy link
Owner

eskerda commented Jul 9, 2016

Looks good, thanks

@eskerda eskerda merged commit e44ba59 into eskerda:master Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants