Skip to content

fix auto approval for compound bash / 修复复合 bash 自动审批#6137

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/auto-compound-bash-approval
Jul 7, 2026
Merged

fix auto approval for compound bash / 修复复合 bash 自动审批#6137
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/auto-compound-bash-approval

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Make compound bash segment fallback honor the permission policy mode.
  • Prevent Auto approval from prompting on uncovered compound bash segments when writer fallback is allow.
  • Add regression coverage for a PowerShell-style pipeline/semicolon command across allow, ask, and deny modes.

Root Cause

Compound bash commands are decomposed into simple-command segments. Uncovered segments previously forced Ask directly instead of applying the same writer fallback used by atomic bash commands, so Auto approval could still show a bash approval prompt.

Tests

  • go test ./internal/permission
  • go test ./internal/control

@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jul 7, 2026
@SivanCola SivanCola changed the title fix auto approval for compound bash fix auto approval for compound bash / 修复复合 bash 自动审批 Jul 7, 2026
@SivanCola SivanCola marked this pull request as ready for review July 7, 2026 04:02
@SivanCola SivanCola requested a review from esengine as a code owner July 7, 2026 04:02
@SivanCola SivanCola merged commit 3b677cf into esengine:main-v2 Jul 7, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant