Skip to content

Reconcile startup readiness metadata / 对账启动 ready 元数据#6136

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/ready-meta-reconcile
Jul 7, 2026
Merged

Reconcile startup readiness metadata / 对账启动 ready 元数据#6136
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/ready-meta-reconcile

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Add an active-tab-only startup metadata reconcile loop when the frontend still sees ready=false without a startup error.
  • Guard the loop with a per-tab token so tab switches, startup errors, backend activation, or readiness invalidate stale probes.
  • Keep the probe read-only: it calls only MetaForTab for the active tab and does not activate tabs, reload history, rebuild controllers, or toggle approval mode.
  • Add a regression test for the missed-ready-event path that previously made toggling approval mode appear to unlock send.

Verification

  • cd desktop/frontend && npx tsx src/__tests__/ready-meta-reconcile.test.tsx
  • cd desktop/frontend && npx tsx src/__tests__/ready-event-meta-sync.test.tsx
  • cd desktop/frontend && npm run test:typecheck
  • cd desktop/frontend && npm run test
  • cd desktop/frontend && npm run build
  • cd desktop && go test -short .
  • git diff --check

@SivanCola SivanCola requested a review from esengine as a code owner July 7, 2026 03:45
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jul 7, 2026
@SivanCola SivanCola merged commit 27962e7 into esengine:main-v2 Jul 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant