Skip to content

Migrate diagnostic sidecars through overlong-name reconciliation / 超长名整理时迁移诊断 sidecar#6126

Merged
SivanCola merged 3 commits into
esengine:main-v2from
SivanCola:fix/sidecar-reconcile-and-doctor-out
Jul 6, 2026
Merged

Migrate diagnostic sidecars through overlong-name reconciliation / 超长名整理时迁移诊断 sidecar#6126
SivanCola merged 3 commits into
esengine:main-v2from
SivanCola:fix/sidecar-reconcile-and-doctor-out

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • The overlong-name reconcile pass filtered by a bare .jsonl suffix, so an .events.jsonl or .conflicts.jsonl whose name crossed the 224-byte bound (owner stem between 209 and 224 bytes) was renamed into a fake session with fabricated meta, while the owning transcript's rename orphaned both logs under the retired stem. Filter with store.IsSessionTranscriptName and carry the event log, event index, and conflict log through migrateSessionSidecars like the other owned sidecars.
  • reasonix doctor session now also accepts --out=PATH (equals form); empty --out= is a usage error.
  • New regression test verified red-without-fix / green-with-fix.

Stacked on #6120 (needs store.SessionConflictLog and the doctor session subcommand; contains its commits until it merges — review the top commit only).

Tests

  • go test ./internal/agent ./internal/cli
  • golangci-lint run (clean)

merge-order-check added 3 commits July 7, 2026 01:17
…ate them

The overlong-name pass filtered by a bare .jsonl suffix, so an
.events.jsonl or .conflicts.jsonl whose name crossed the 224-byte bound
(owner stem between 209 and 224 bytes) was renamed into a fake session
with fabricated meta, while the real transcript's rename orphaned both
logs under the retired stem. Filter with store.IsSessionTranscriptName
and carry the event log, event index, and conflict log through
migrateSessionSidecars like the other owned sidecars.

Also accept --out=PATH (equals form) in reasonix doctor session.
@SivanCola SivanCola requested a review from esengine as a code owner July 6, 2026 18:35
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) agent Core agent loop (internal/agent, internal/control) labels Jul 6, 2026
@SivanCola SivanCola merged commit 1c17637 into esengine:main-v2 Jul 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant