fix(desktop): make session trash tolerate missing artifacts#6085
Merged
Conversation
If the source disappears while the copy fallback is running, copyAndRemove now removes the partially written destination before treating the artifact as already moved, so the trash never keeps a truncated transcript that a later restore would resurrect. Real copy failures still propagate and leave the source untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The system cannot find the path specifiedand leave the sidebar topic feeling stuck.Verification
cd desktop && go test . -run "Test(MovePathIfExistsCopyFallback|CopyFallbackTreatsMissingSourceAsAlreadyMoved|CopyFallbackRemovesPartialTargetWhenSourceVanishesMidCopy|CopyFallbackKeepsErrorWhenSourceStillExists|TrashTopicRemovesStaleMissingSession|TrashTopicMovesRelatedSessionsToTrash|TrashTopicValidTrashRemovesEmptyLiveStub)"cd desktop && go test . -run "Test(DeleteSessionFile|MovePathIfExists|CopyAndRemove|CopyFallback|TrashTopic|Restore.*Session|PurgeTrashedSession)"cd desktop && go test .git diff --checkCache impact
Cache-impact: none, desktop session cleanup only; this does not change provider-visible prompts, tool schemas, request serialization, or model context construction.
Cache-guard:
cd desktop && go test .plus focused session trash regression tests listed above.System-prompt-review: N/A