Skip to content

Avoid blocking metadata hydration on git branch probes / 避免 git 分支探测阻塞元信息刷新#6056

Merged
SivanCola merged 3 commits into
esengine:main-v2from
SivanCola:fix/desktop-meta-git-branch-async
Jul 6, 2026
Merged

Avoid blocking metadata hydration on git branch probes / 避免 git 分支探测阻塞元信息刷新#6056
SivanCola merged 3 commits into
esengine:main-v2from
SivanCola:fix/desktop-meta-git-branch-async

Conversation

@SivanCola

@SivanCola SivanCola commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Make the desktop metadata git-branch helper return cached or stale branch data immediately instead of waiting for git on the hydration path.
  • Refresh expired or missing git branch metadata in the background, while keeping WorkspaceChanges on the synchronous fresh git path.
  • Update MetaForTab and workspace branch-cache tests for the async metadata contract.

Context

This addresses one likely contributor to #5909 where tab.hydrate meta can take around 2s during topic activation. The PR does not close the issue because the thread contains multiple performance-lag shapes.

Tests

  • cd desktop && go test . -count=1 -run '^(TestMetaForTabIncludesWorkspaceContext|TestWorkspaceGitBranch|TestWorkspaceGitBranchForMeta|TestWorkspaceGitDisablesDaemonSpawns)'
  • git diff --check
  • cd desktop && go test ./...

@SivanCola SivanCola requested a review from esengine as a code owner July 6, 2026 03:26
@github-actions github-actions Bot added desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development labels Jul 6, 2026
@SivanCola SivanCola merged commit 0f4e3f3 into esengine:main-v2 Jul 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant