fix(desktop): preserve conflicting trash sessions#6037
Merged
Conversation
github-actions
Bot
added
v2
SivanCola
force-pushed
the
fix/unique-trash-conflict
branch
from
d89c1a0 to
b9beebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.trash/<key>/<key>entry already exists..trash-meta.jsonso restore and purge keep working.Root Cause
Recovery/session trash entries used the session basename as both the logical key and the storage item directory. When an older recovery copy was already in trash and the live recovery later diverged, delete refused with
session already exists in trashto avoid overwriting either history.Validation
cd desktop && go test . -run 'TestDeleteSessionValidTrash(RenamesDifferentLiveConflict|RemovesEmptyLiveStub|RemovesDuplicateLiveSession)|TestDeleteSessionTrashConflictKeepsRuntime|TestDeleteSessionKeepsDuplicateLiveSessionHeldByOtherRuntime|TestRestoreSessionRejectsOpenEmptyLiveStub|TestRestoreTrashedSessionFileFromUniqueTrashItem' -vcd desktop && go test . -run 'TestReconcileDesktopCleanupPendingDelete(MovesArtifactsToTrash|ReusesExistingTrashDir|MovesRemainingSidecars)|TestDeleteSessionFile|TestValidateSessionTrashTargetKeepsDiscardableLiveStub|TestTrashPathsBlockedWhileLeaseHeld|TestRestoreTrashedSessionFile|TestPurgeTrashedSessionFile|TestListTrashedSessionFilesRejectsSymlinkEscape|TestTrashTopic' -vcd desktop && go test .