Add Windows sandbox escape approvals#6032
Merged
SivanCola merged 1 commit intoJul 5, 2026
Merged
Conversation
ae9d0f7 to
7100b22
Compare
7100b22 to
4f3bfa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox_escapeapproval path for Windows bash sandbox fallback.Validation
go test ./internal/tool/builtin ./internal/control ./internal/i18n ./internal/agent ./internal/sandbox ./internal/acp ./internal/cliGOOS=windows GOARCH=amd64 go test -c -o /tmp/reasonix-internal-sandbox-windows.test ./internal/sandboxGOOS=windows GOARCH=amd64 go test -c -o /tmp/reasonix-internal-tool-builtin-windows.test ./internal/tool/builtinpnpm --dir desktop/frontend exec tsx src/__tests__/approval-modal-file-reference.test.tsxpnpm --dir desktop/frontend exec tsc --noEmit -p tsconfig.test.jsongit diff --checkCache
Cache-impact: low - Adds execution-time sandbox escape approvals and localized approval copy; tool schema/order, provider request serialization, and stable system prompt remain unchanged.
Cache-guard: Verified with focused approval and owning-package tests above; no prefix-cache guard was added because this path does not change provider-visible prefix bytes.
Notes