Skip to content

Add Windows sandbox escape approvals#6032

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/windows-sandbox-escape-prompt
Jul 5, 2026
Merged

Add Windows sandbox escape approvals#6032
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/windows-sandbox-escape-prompt

Conversation

@SivanCola

@SivanCola SivanCola commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a fresh one-shot sandbox_escape approval path for Windows bash sandbox fallback.
  • Keep Windows sandbox helper failures fail-closed unless the user explicitly allows one unconfined rerun.
  • Localize approval-facing copy for sandbox escape, plan-mode read-only trust, memory approvals, tool labels, and related CLI/TUI prompts.
  • Add frontend mocks and regression tests for Chinese approval rendering and one-shot fresh approval actions.

Validation

  • go test ./internal/tool/builtin ./internal/control ./internal/i18n ./internal/agent ./internal/sandbox ./internal/acp ./internal/cli
  • GOOS=windows GOARCH=amd64 go test -c -o /tmp/reasonix-internal-sandbox-windows.test ./internal/sandbox
  • GOOS=windows GOARCH=amd64 go test -c -o /tmp/reasonix-internal-tool-builtin-windows.test ./internal/tool/builtin
  • pnpm --dir desktop/frontend exec tsx src/__tests__/approval-modal-file-reference.test.tsx
  • pnpm --dir desktop/frontend exec tsc --noEmit -p tsconfig.test.json
  • git diff --check

Cache

Cache-impact: low - Adds execution-time sandbox escape approvals and localized approval copy; tool schema/order, provider request serialization, and stable system prompt remain unchanged.
Cache-guard: Verified with focused approval and owning-package tests above; no prefix-cache guard was added because this path does not change provider-visible prefix bytes.

Notes

  • Desktop React UI localizes fixed approval templates even when an older backend payload still carries the English template.
  • Commands, paths, MCP server/tool names, and model-provided text remain unchanged.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) skills Skill system (internal/skill, internal/tool) agent Core agent loop (internal/agent, internal/control) labels Jul 5, 2026
@SivanCola SivanCola force-pushed the fix/windows-sandbox-escape-prompt branch 9 times, most recently from ae9d0f7 to 7100b22 Compare July 5, 2026 18:37
@SivanCola SivanCola force-pushed the fix/windows-sandbox-escape-prompt branch from 7100b22 to 4f3bfa9 Compare July 5, 2026 19:00
@SivanCola SivanCola marked this pull request as ready for review July 5, 2026 19:13
@SivanCola SivanCola requested a review from esengine as a code owner July 5, 2026 19:13
@SivanCola SivanCola merged commit 3211ad6 into esengine:main-v2 Jul 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) desktop Wails desktop app (desktop/**) skills Skill system (internal/skill, internal/tool) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant