fix(desktop): disable "Summarize after this" on the last message#6001
Merged
SivanCola merged 2 commits intoJul 5, 2026
Merged
Conversation
The "Summarize after this" (summ-from) button was enabled on the last user message even though there is nothing after it to summarize. This mirrors the existing check that disables "Summarize before this" on the first message (turn <= 0). - Add isLastTurn prop to TurnActions component - Check isLastTurn in actionDisabledReason for summ-from scope - Pass isLastTurn from Transcript hot zone and WarmTurnItems - Add i18n key rewind.disabledNoLater (en/zh/zh-TW) Closes esengine#5744
github-actions
Bot
added
v2
Use the same authoritative question turn mapping for the last-turn check that TurnActions uses for rewind actions. This keeps "Summarize after this" disabled on the last visible turn even when restored or paged history uses non-contiguous checkpoint turns. Co-authored-by: SivanCola <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Summarize after this" button (summ-from) is enabled on the last user message, but there is nothing after it to summarize. This is inconsistent with the existing behavior that correctly disables "Summarize before this" on the first message (turn <= 0).
Issue: #5744
Root Cause
Message.tsx:574-589—actionDisabledReason("summ-from")checkscanConversationbut does not check whether the current turn is the last turn.Changes
Message.tsxisLastTurnprop toTurnActions; check it inactionDisabledReasonforsumm-fromTranscript.tsxisLastTurn={turn === maxTurn}from hot zone and warm zone renderingen.tsrewind.disabledNoLaterkeyzh.tsrewind.disabledNoLaterkeyzh-TW.tsrewind.disabledNoLaterkeyTesting
summ-uptocheck on turn 0