Skip to content

Explain unavailable bash sandbox recovery / 说明 bash 沙箱不可用时的恢复方式#5983

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/bash-sandbox-unavailable-guidance
Jul 5, 2026
Merged

Explain unavailable bash sandbox recovery / 说明 bash 沙箱不可用时的恢复方式#5983
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/bash-sandbox-unavailable-guidance

Conversation

@SivanCola

@SivanCola SivanCola commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add one shared bash sandbox unavailable message that explains why bash = "enforce" refuses execution when no OS sandbox backend is present.
  • Surface the recovery path in the bash tool error, startup warning, doctor, CLI /sandbox, generated config comments, desktop settings copy, and docs.
  • Correct the public docs that still described non-macOS hosts as falling back to unconfined shell execution.

Root cause

Reasonix 1.16 intentionally fails closed when bash = "enforce" cannot wrap commands in an OS sandbox. Earlier versions could run unconfined on hosts without the backend, so users saw a sudden full bash refusal after upgrading.

Cache review

Cache-impact: low - touches cache-sensitive files, but does not change the stable system prompt, provider request serialization, tool schema bytes/order, MCP registration, compaction, or memory injection; only stderr/tool-error diagnostics and documentation/settings copy change.
Cache-guard: reviewed against references/cache-first.md; focused tests cover the changed packages and scripts/check-cache-impact.sh passes with these notes.
System-prompt-review: reviewed internal/boot/boot.go; the change only reuses the shared sandbox-unavailable stderr warning before tool registration and does not alter sysPrompt construction or provider-visible prefix ordering.

Validation

  • go test ./internal/sandbox ./internal/tool/builtin ./internal/doctor ./internal/boot
  • go test ./internal/config
  • go test ./internal/cli
  • pnpm --dir desktop/frontend typecheck

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) skills Skill system (internal/skill, internal/tool) config Configuration & setup (internal/config) labels Jul 5, 2026
@SivanCola SivanCola marked this pull request as ready for review July 5, 2026 05:50
@SivanCola SivanCola requested a review from esengine as a code owner July 5, 2026 05:50
@SivanCola SivanCola merged commit 080e0d1 into esengine:main-v2 Jul 5, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) skills Skill system (internal/skill, internal/tool) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant