Skip to content

Surface effort switch blockers / 显示推理力度切换阻塞原因#5971

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/effort-switch-notices
Jul 5, 2026
Merged

Surface effort switch blockers / 显示推理力度切换阻塞原因#5971
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/effort-switch-notices

Conversation

@SivanCola

@SivanCola SivanCola commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Show a warning notice when desktop reasoning effort changes are rejected instead of silently refreshing back to auto.
  • Classify common non-fatal blockers: active work, session lease conflicts, startup-in-progress, startup failure, and stale tab retries.
  • Add focused frontend coverage for the notice mapping and rejected effort switch path.

Why

Refs #5956. The effort menu can expose max correctly while the controller rebuild fails; the UI previously swallowed that error, making the click look like it did nothing.

The root session lease race is already fixed by #5968. This PR is the UX follow-up: it surfaces rejected effort changes with actionable frontend notices so future backend blockers are visible instead of looking like a no-op.

Validation

  • pnpm --dir desktop/frontend exec tsx src/__tests__/use-controller-meta.test.ts
  • pnpm --dir desktop/frontend exec tsx src/__tests__/use-controller-cancel-reconcile.test.tsx
  • pnpm --dir desktop/frontend exec tsc --noEmit -p tsconfig.test.json
  • git diff --check

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) and removed v2 Go rewrite (1.x) — main-v2 branch, active development labels Jul 5, 2026
@SivanCola SivanCola marked this pull request as ready for review July 5, 2026 05:59
@SivanCola SivanCola requested a review from esengine as a code owner July 5, 2026 05:59
@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jul 5, 2026
@SivanCola SivanCola merged commit 07794a0 into esengine:main-v2 Jul 5, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant