fix(session): recover stale controller transcripts#5856
Merged
Conversation
This was referenced Jul 3, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revision,content_digest,writer_id) so snapshot/rewrite saves only commit from the controller's recorded disk baseline, while listing/meta updates preserve those persistence fieldsflock/ WindowsLockFileExlease files, and wire desktop tab build/rebind/close/recovery paths so one writable runtime owns a session pathRefs #5783
Verification
go test -count=1 ./internal/agentgo test -count=1 ./internal/control ./internal/bootcd desktop && go test -count=1 .pnpm --dir desktop/frontend typecheckpnpm --dir desktop/frontend check:csspnpm --dir desktop/frontend exec tsx src/__tests__/project-tree-runtime.test.tsGOOS=windows GOARCH=amd64 go test -c ./internal/agent -o "<tmp>/agent.test.exe"GOOS=linux GOARCH=amd64 go test -c ./internal/agent -o "<tmp>/agent.test"git diff --checkCache impact
Cache-impact: none; this changes session persistence/recovery, sidecar metadata, and desktop runtime ownership, not provider-visible prompts, model input shaping, tool schemas, or cache key behavior.
Cache-guard:
go test -count=1 ./internal/agent;go test -count=1 ./internal/control ./internal/boot;cd desktop && go test -count=1 .;pnpm --dir desktop/frontend typecheck;pnpm --dir desktop/frontend check:css;pnpm --dir desktop/frontend exec tsx src/__tests__/project-tree-runtime.test.ts;GOOS=windows GOARCH=amd64 go test -c ./internal/agent -o "<tmp>/agent.test.exe";GOOS=linux GOARCH=amd64 go test -c ./internal/agent -o "<tmp>/agent.test".System-prompt-review: no provider-visible system prompt, memory prefix, output style, skill index, or tool schema behavior changes.