Integrate desktop sidebar runtime fixes / 整合桌面侧边栏运行态修复#4942
Merged
SivanCola merged 2 commits intoJun 20, 2026
Conversation
github-actions
Bot
added
v2
SivanCola
force-pushed
the
fix/sidebar-resilience-integration
branch
from
1538c6c to
b385e16
Compare
This was referenced Jun 20, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1538c6c477
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Combine the sidebar/session resilience work from related PRs into one integration change. - Preserve session runtime teardown before trash moves and CloseTab snapshot ordering. - Reset planner sessions on desktop tab activation changes. - Add bounded sidebar sidecar reads and safe ListProjectTree fan-out without caching runtime ProjectNode state. - Keep REASONIX_DEV single-instance bypass while allowing path-scoped release/dev locks. Co-authored-by: ttmouse <[email protected]> Co-authored-by: GTC2080 <[email protected]> Co-authored-by: liaoyl830 <[email protected]> Co-authored-by: myipanta <[email protected]>
SivanCola
force-pushed
the
fix/sidebar-resilience-integration
branch
from
b385e16 to
e89419a
Compare
This was referenced Jun 20, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This integration PR combines the directly related desktop sidebar/session runtime work into one conflict-resolved branch on top of
main-v2.It keeps the useful sidebar resilience and performance pieces while avoiding the unsafe full
ProjectNoderesult cache from #4889: runtime fields are recomputed on eachListProjectTreecall, soOpen,Running, andStatuscannot be served from stale tree state.Integrated PR contributions
main-v2; this PR builds on that cache/fan-out direction instead of replacing it.ListProjectTreerebuilds, concurrent project topic sidecar loading, avoiding repeated topic-title file reads, and path-scoped single-instance IDs. The unsafe full-tree result cache and un-migrated config-dir move are intentionally not included.Notes
REASONIX_DEVstill skips the single-instance lock for contributor workflows.desktopConfigDir()remains on the existing platform config path; this PR does not move tabs/projects to~/.reasonixwithout migration.ListProjectTreehas moved on.Verification
go test -run 'TestSingleInstance|TestOpenProjectTabResolvesProjectSessionFromLegacyDir|TestProjectTreeShowsBackgroundJobStatus|TestCloseTabNoResurrectionFromAutosave|TestTurnDonePersistsSession|TestTrashTopic|TestDeleteSession' -count=1go test -run 'TestSetSessionTitlePreservesExistingTitlesWhenTimedReadSlotsFull|TestTopicMetadataUpdatesPreserveExistingEntriesWhenTimedReadSlotsFull|TestSetActiveTabDoesNotResetPlannerSession|TestCloseActiveTabDoesNotResetSurvivorPlannerSession|TestCloseReadOnlyChannelTabDoesNotSnapshotTranscript|TestOpenChannelSessionForTabIsReadOnly' -count=1go test ./...fromdesktop/git diff --check origin/main-v2...HEAD