test(desktop): cover PE tab handoff isolation#4930
Closed
GTC2080 wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
v2
Collaborator
|
Thanks @GTC2080. I reviewed this PE tab handoff isolation test PR while consolidating the related PE work into #4938. This remains a useful testing direction for #4926, but the current integration PR is focused on executor handoff nudging, no-op planner conclusions, MCP/tool handoff context, and planner routing. Since #4930 is not part of that final code path, I credited it in #4938 and am closing this PR as part of the consolidation cleanup. If #4926 remains reproducible on current main-v2, a fresh isolated follow-up test/fix can reopen that thread directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boot.Buildpath.main-v2already keeps the runtime path isolated; no production change is included because I could not reproduce a project-level handoff buffer leak on the latest base.Refs #4926
Verification
cd desktop && go test ./... -run TestPlanExecuteTabsUnderSameProjectKeepPlannerHandoffsIsolated -count=2go test ./internal/control -run 'Test(NewSession|Resume)ResetsTwoModelPlannerContext' -count=1go test ./internal/agent ./internal/control -count=1cd desktop && go test ./... -count=1go test ./... -count=1go vet ./...cd desktop && go vet ./...Cache impact
Cache-impact: none — test-only change; no system prompt, tool schema, provider request serialization, or runtime prompt construction changes.
Cache-guard:
cd desktop && go test ./... -run TestPlanExecuteTabsUnderSameProjectKeepPlannerHandoffsIsolated -count=2System-prompt-review: N/A