Skip to content

fix(agent): allow guidance-only executor handoffs#4898

Closed
GTC2080 wants to merge 1 commit into
esengine:main-v2from
GTC2080:GTC/fix-executor-handoff-guidance-nudge
Closed

fix(agent): allow guidance-only executor handoffs#4898
GTC2080 wants to merge 1 commit into
esengine:main-v2from
GTC2080:GTC/fix-executor-handoff-guidance-nudge

Conversation

@GTC2080

@GTC2080 GTC2080 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes [Bug] Plan Execute dual-model: executor handoff nudge forces task invention on guidance-only turns #4867 by allowing PE executor handoffs to finish with a text-only answer when the original turn or planner output is clearly user-facing guidance, a summary, or a follow-up question.
  • Keeps the existing handoff nudge for real work tasks and deferral-style answers, so code/file changes still require executor tool calls.
  • Updates the executor handoff instructions to avoid invented local tool calls for pure guidance-only turns.

Verification

  • go test ./internal/agent -run 'TestCoordinator(AllowsGuidanceOnlyExecutorHandoff|NudgesExecutorThatAnswersWithoutActing|NudgesWorkTaskEvenIfPlannerMentionsUserGuidance|DoesNotNudgeExecutorThatActs)' -count=1
  • go test ./internal/agent -count=1
  • go test ./...
  • (cd desktop && go test ./...) (passes; local linker prints the existing duplicate -lobjc warning)
  • go vet ./...
  • (cd desktop && go vet ./...)
  • git diff --check
  • gofmt -l .

Cache impact

Cache-impact: low - touches the executor handoff gate and one handoff user-turn instruction; system prompt and tool schemas are unchanged.
Cache-guard: Added focused coordinator regressions for guidance-only handoffs and for preserving the work-task nudge; also ran go test ./internal/agent -count=1 and go test ./....
System-prompt-review: N/A

@SivanCola

Copy link
Copy Markdown
Collaborator

Thanks @GTC2080. I consolidated this guidance-only executor handoff fix into #4938.

What was kept:

  • guidance-only, summary, question, and manual-instruction PE handoffs can now finish with a text-only executor answer;
  • real work tasks still keep the missing-action nudge so the executor cannot just restate the plan;
  • regression coverage preserves both sides of that behavior.

Your investigation and implementation are credited in #4938 under Repository Contributor Credits. Closing this PR in favor of the integration PR.

@SivanCola SivanCola closed this Jun 20, 2026
@GTC2080 GTC2080 deleted the GTC/fix-executor-handoff-guidance-nudge branch June 22, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Plan Execute dual-model: executor handoff nudge forces task invention on guidance-only turns

2 participants