sidebar: 会话列表加载性能优化#4858
Conversation
- 并发读取所有工作区的会话目录(goroutine + WaitGroup) - 内存缓存 sessionListCache:同次会话内重渲染零 I/O - 磁盘缓存 sessionDiskCache:签名校验后跳过 LoadBranchMeta + previewSession - 会话变更时(emitProjectTreeChanged)自动失效缓存 效果:10+ 工作区 1100+ 会话,首次 0.87s vs 1.6s,二次启动 8ms
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d29e591100
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: SivanCola <[email protected]>
|
Follow-up integration #4942 has now been merged. This PR was already merged into Thank you for the original performance work. |
问题
ListProjectTree每次被调用(启动、侧边栏渲染、会话变更)时,都会对 32 个工作区目录逐一调用ListSessions。每个目录的ListSessions需要遍历所有.jsonl文件,读取.jsonl.meta元数据并解码 JSONL 文件获取预览文本。实测 1121 个会话,每次耗时 1.6 秒。多工作区用户(10+ 个项目,每个几十个对话)在启动时感知尤为明显。
改动
1 个文件,310 行增量,在
desktop/tabs.go的ListProjectTree中增加了三层缓存:并发读取
32 个会话目录改为 goroutine 并发读取(
sync.WaitGroup),共享 map 合并用mergeMu保护。首次冷启动从 1.6s 降至 0.87s。内存缓存(
sessionListCache)同一次应用会话内,第二次及后续调用
ListProjectTree直接从内存返回缓存结果,不触发任何文件 I/O。emitProjectTreeChanged时自动失效。磁盘缓存(
sessionDiskCache)首次读取后将结果持久化到
~/.reasonix/project-session-cache.json。下次启动时通过目录签名(文件名 + mtime + 大小)校验缓存有效性——签名匹配则直接从缓存文件恢复(8ms),跳过所有文件读取。签名不匹配时回退到完整读取并更新缓存。效果(实测 1121 个会话,32 个目录)
兼容性
emitProjectTreeChanged新增两条 invalidate 调用,不影响原有事件流~/.reasonix/下,文件缺失时自动降级回完整读取共同贡献者