fix(agent): reinforce executor tool handoff#4842
Closed
GTC2080 wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
v2
Collaborator
|
Thanks @GTC2080. I consolidated the executor tool-schema/MCP handoff reinforcement into #4938. What was kept:
Your contribution is credited in #4938 under Repository Contributor Credits. Closing this PR in favor of the integration PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
go test ./internal/agent -run TestCoordinatorHandoffAffirmsExecutorToolSchemasWhenPlannerClaimsNoMCP -count=1go test ./internal/agent -run 'TestCoordinator' -count=1go test ./internal/agent -count=1go test ./...cd desktop && go test ./...go vet ./...cd desktop && go vet ./...git diff --checkCache impact
Cache-impact: low - changes only the two-model executor handoff/retry user message, not the cache-stable system prompt, memory prefix, skill index, provider request shape, or tool schema bytes. The added tool-name summary is bounded.
Cache-guard:
go test ./internal/agent -run TestCoordinatorHandoffAffirmsExecutorToolSchemasWhenPlannerClaimsNoMCP -count=1;go test ./....System-prompt-review: N/A - no system prompt, memory prefix, output style, or skill index behavior change.