fix(desktop): close CloseTab-Snapshot/DeleteSession race window#4400
Closed
myipanta wants to merge 1 commit into
Closed
fix(desktop): close CloseTab-Snapshot/DeleteSession race window#4400myipanta wants to merge 1 commit into
myipanta wants to merge 1 commit into
Conversation
Move Snapshot() inside the lock before delete(a.tabs, tabID) to prevent a race where DeleteSession removes session files after the tab is unregistered but before the deferred Snapshot writes them back. Fixes esengine#4384.
github-actions
Bot
added
v2
Collaborator
Collaborator
|
Closing this in favor of the merged integration PR #4942. The CloseTab/DeleteSession resurrection fix from this PR was kept/adapted in #4942: writable tabs are snapshotted before unregistering, with follow-up handling so read-only channel transcripts remain browse-only on close. @myipanta is credited in #4942's contribution table and commit co-author trailers. Thank you for the race-window fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Snapshot() inside the lock before delete(a.tabs, tabID) to prevent a race where DeleteSession removes session files after the tab is unregistered but before the deferred Snapshot writes them back.
Fixes #4384.