fix: crash when [Symbol.iterator] is declared in a class.#78
Merged
h13i32maru merged 2 commits intoesdoc:masterfrom Sep 12, 2015
hatashiro:iterator
Merged
fix: crash when [Symbol.iterator] is declared in a class.#78h13i32maru merged 2 commits intoesdoc:masterfrom hatashiro:iterator
h13i32maru merged 2 commits intoesdoc:masterfrom
hatashiro:iterator
Conversation
Contributor
Author
|
This may conflict with another PR which has just been merged because of Any comment for the rest of the patch? |
Member
added 2 commits
September 12, 2015 17:37
#73 Use Escodegen to parse method names using ES6's computed property names.
Contributor
Author
|
Updated PR using the suggested escodegen. Please feel free to comment further! |
Member
|
Wow! Thanks updated! |
h13i32maru
added a commit
that referenced
this pull request
Sep 12, 2015
fix: crash when [Symbol.iterator] is declared in a class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've just uploaded the previous PR and I found the issue #73 is somewhat similar to it. However, I cannot be sure if this way is what you would like. Any comment will be welcomed, so that I can modify along with it.
Cheers 👍