fix(parser): support parsing expressions in extend clause by dimitryvolkov · Pull Request #409 · esdoc/esdoc

dimitryvolkov · 2017-03-29T12:09:22Z

Currently esdoc fails for code containing a call expression in 'extends' clauses which is a supported feature and is popular with mixins.

Failing code:

function mix() {
	return {
		with: function () {
			return class { };
		}
	};
}
class Test extends mix().with() { }

h13i32maru

Thanks

oravecz · 2017-09-05T20:13:45Z

What should this PR allow? I didn't see any change in my web component docs which are using mixins using a different approach.

Should this PR allow the identifications of mixins when implemented such as these techniques?

class Test extends Mixin1( Mixin2( HTMLElement ) )

class Test extends Composable(HTMLElement).compose( Mixin1, Mixin2 )

fix(parser): support parsing expressions in extend clause

389630a

h13i32maru approved these changes Sep 3, 2017

View reviewed changes

h13i32maru merged commit 33d9c39 into esdoc:master Sep 3, 2017

Provide feedback