Fix crash with guessing return type#364
Merged
h13i32maru merged 4 commits intoesdoc:masterfrom Jan 2, 2017
Merged
Conversation
Contributor
Author
|
Anyone? (If it helps, I can rebase branch to latest master) |
esdoc try to guess function return type when not `@return` tag found. When return type is Object, most times it can determine it's shape from AST. But when this object contains rest spread operator, it became compicated (for ex `return { ...obj }`, theorethically we can try track deeper and determine shape of `obj`, but for now we simple break guessing with `*`). In any case, this commit fixed crash with this case, because when AST node contain object with type `SpreadProperty`, it of course has no `key`.
8cbcdd7 to
f187817
Compare
Contributor
Author
|
I just rebase and fixed this branch. |
Member
|
@vovkasm Sorry for late reply 🙇 |
Member
|
And I improved to guess object spread. Thanks. |
Contributor
Author
|
Cool! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal sample to reproduce crash:
Esdoc try to guess function return type when not
@returntag found. When return type is Object, most times it can determine it's shape from AST. But when this object contains rest spread operator, it became compicated (for exreturn { ...obj }, theorethically we can try track deeper and determine shape ofobj, but for now we simple break guessing with*). In any case, this commit fixed crash with this case, because when AST node contain object with typeSpreadProperty, it of course has nokey.