handle repo urls that start with git+#236
Closed
jamsyoung wants to merge 1 commit intoesdoc:masterfrom
jamsyoung:issue-235
Closed
handle repo urls that start with git+#236jamsyoung wants to merge 1 commit intoesdoc:masterfrom jamsyoung:issue-235
jamsyoung wants to merge 1 commit intoesdoc:masterfrom
jamsyoung:issue-235
Conversation
Member
|
Thanks this PR 😄 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #235
This PR updates the existing logic around package.json repository property. It does not change it to read from the "homepage" property. I felt switching from repository to homepage would probably break more people than just updating the logic around repository.