Skip to content

"Repository" link pulling from incorrect property in package.json  #235

@jamsyoung

Description

@jamsyoung

I am not sure when this behavior started. It def exists in node 5.6.0 with npm 3.7.5.

When doing "npm init" the default format for the "repository" url starts with git+

Example, edited for brevity. Showing only what is set by the "git repository" question.

$ npm init
git repository: https://github.com/cnnlabs/something.git
About to write to /Users/jyoung/dev/test/package.json:

{
  "repository": {
    "type": "git",
    "url": "git+https://github.com/cnnlabs/something.git"
  },
  "bugs": {
    "url": "https://github.com/cnnlabs/something/issues"
  },
  "homepage": "https://github.com/cnnlabs/something#readme"
}

ESDoc pulls the repository.url for the href of the "Repository" link, which is invalid since it starts with git+.

It would be more appropriate to pull the homepage property.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions