Repository navigation
Check is_driver() on drivers in pefile-tests - #650
Merged
j-t-1 merged 1 commit intoNov 5, 2026
Merged
Conversation
the two files the old checks used are not in pefile-tests . corkami driver.sys and the lief PE64_x86-64_atapi.sys are , and radare2 shows both as Native and importing from the kernel , ntoskrnl.exe!DbgPrint for the first and NTOSKRNL.exe for the second . each is checked with fast_load , where is_driver() has to parse the imports itself , and without it . the 64 bit one names the kernel in upper case , so the test fails if the .lower() on the import names goes away . cmd.exe is the negative case .
j-t-1
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #584 .
the two files the old checks used are not in pefile-tests . corkami
driver.sysand the liefPE64_x86-64_atapi.sysare , and radare2 shows both as Native and importing from the kernel ,ntoskrnl.exefor the first andNTOSKRNL.exefor the second . each is checked with and withoutfast_load, andcmd.exeis the negative case . the upper case name means the test fails if the.lower()on the import names goes away .the plaso file from #322 is still public ,
test_data/test_driver.sysin log2timeline/plaso ( apache 2.0 , 1024 bytes ) , if you want it back in pefile-tests . it importsDbgPrintfromntoskrnl.exetoo andis_driver()is true for it .