Repository navigation
Check checksums on corkami files in pefile-tests - #649
Merged
j-t-1 merged 3 commits intoNov 8, 2026
Merged
Conversation
the four commented out checks use files from the old checksum folder , which is not in pefile-tests . these use corkami files that are . multiss_drv.sys , multiss_gui.exe and multiss_con.exe only differ at offset 0x9c , the Subsystem field , set to 1 , 2 and 3 . all three carry the checksum of the driver , 0x255c , so the driver one is good and the other two are off by 1 and 2 . tinydrivXP.sys is the 97 byte file whose optional header runs past the end , it was the case erocarrera#635 fixed , and that check fails on the pefile from before erocarrera#635 . the values match radare2 , which prints the computed checksum next to the one in the header ( rabin2 -I , cmp.csum and hdr.csum ) , and a separate implementation of the checksum . pefile , radare2 and that implementation agree on every file in pefile-tests that radare2 loads , 354 of 356 .
j-t-1
approved these changes
Nov 5, 2026
j-t-1
left a comment
j-t-1
left a comment
Collaborator
There was a problem hiding this comment.
Is the suggested comment okay?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #584 .
the four commented out checks use files from a
checksumfolder that is not in pefile-tests . these use corkami files that are there .multiss_drv.sys,multiss_gui.exeandmultiss_con.exeonly differ at offset 0x9c , the Subsystem field , set to 1 , 2 and 3 . all three carry the checksum of the driver , 0x255c , so the driver one is good and the other two give 0x255d and 0x255e .tinydrivXP.sysis 97 bytes and its optional header runs past the end . it is the case #635 fixed , and this check fails on the pefile from before #635 .radare2 prints the computed checksum next to the one in the header (
rabin2 -I,cmp.csumandhdr.csum) and gives the same values . pefile , radare2 and a separate implementation of the checksum agree on all 354 files in pefile-tests that radare2 loads .