Repository navigation
Check the issue 314 file rebases to an unchanged image - #648
Merged
j-t-1 merged 1 commit intoNov 6, 2026
Merged
Conversation
the block for the 97 byte issue 314 file had its asserts commented out , they expected 60624 , which was the count for an older MSVBVM60.DLL . the file has no data directories , so there are no relocations to apply . radare2 finds none either , so the right count is 0 for both ways of rebasing . this also drops the second count_differences and the copy of the load at the end . with the len() guard from erocarrera#314 taken out , the test fails with the IndexError from that issue .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #584 .
the asserts on the 97 byte file from #314 were commented out with
0 != 60624. 60624 is the count the MSVBVM60.DLL block had before #632 , and it came along when that block was copied for this file . the file has no data directories , so there is nothing to relocate , and radare2 finds no relocations either . so the count is 0 both ways .this also drops the second
count_differencesand the copy of the load at the end . with thelen()guard from #314 taken out ofrelocate_image(), the test fails with theIndexErrorfrom that issue .i also checked the 61136 for MSVBVM60.DLL without pefile . the section table from radare2 and a separate walk of the
.relocblocks give 30568 HIGHLOW entries , and rebasing from 0x73420000 to 0x1000000 changes the top two bytes of each one , 61136 bytes .