Repository navigation
Reinstate the kernel32.dll exphash test - #647
Merged
Merged
Conversation
the kernel32.dll in pefile-tests is a different build from the one ce0e9801 was taken from . the old sha256 values from 2022 still match mfc40.dll and the 66c74e4c sample , but neither the old sha256 nor the md5 matches this kernel32.dll . radare2 ( rabin2 -E ) lists the same 954 exports in the same order , and the lowercase , comma joined names give 247dcd1aa98526819ecf3c09cb12ad83 , the same as get_exphash().
j-t-1
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #584 .
ce0e9801...was computed on a different kernel32.dll from the one in pefile-tests . the sha256 values from before 0c747a7 still matchmfc40.dlland the66c74e4csample , so those are the same files , but neither the sha256 nor the md5 value matches this kernel32.dll .radare2 (
rabin2 -Ej) lists the same 954 exports in the same order as pefile , and the md5 of the lowercase names joined with,is247dcd1aa98526819ecf3c09cb12ad83, the valueget_exphash()returns .