ssl: Preserve inet option order in emulated_options#10908
Open
zuiderkwast wants to merge 1 commit intoerlang:maintfrom
Open
ssl: Preserve inet option order in emulated_options#10908zuiderkwast wants to merge 1 commit intoerlang:maintfrom
zuiderkwast wants to merge 1 commit intoerlang:maintfrom
Conversation
Contributor
CT Test Results 2 files 66 suites 25m 58s ⏱️ Results for commit adf3f59. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
IngelaAndin
added
team:PS
IngelaAndin
previously approved these changes
Mar 25, 2026
Contributor
|
@zuiderkwast Please base it so that it can be target for maint. (Or retarget if that is already the case) I think it is a bug that it does not work so we want to fix it for maint too. |
The emulated_options/3 function in tls_socket and dtls_socket used a prepend accumulator pattern without reversing the result, causing inet options to be reversed when passed to gen_tcp:connect/gen_udp:open. This broke the inet_backend option which must be the first option in the list according to gen_tcp and gen_udp documentation. Fix by reversing the Inet accumulator before returning. For dtls_socket, also change the initial Inet accumulator from internal_inet_values() to [] since those values are already appended in the connect and listen call sites. Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
force-pushed
the
ssl-inet-backend-preserve-order
branch
from
f65d56b to
adf3f59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
emulated_options/3function intls_socketanddtls_socketused a prepend accumulator pattern without reversing the result, causing inet options to be reversed when passed togen_tcp:connect/gen_udp:open.This broke the
inet_backendoption which must be the first option in the list according togen_tcpandgen_udpdocumentation.Fix by reversing the Inet accumulator before returning. For
dtls_socket, also change the initial Inet accumulator frominternal_inet_values()to[]since those values are already appended in the connect and listen call sites.Before
After