ssl: Fix reversed Certificate Request sign alg order in tls_handshake_1_3:filter_tls13_algs/1#10695
Conversation
|
|
CT Test ResultsNo tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured. Results for commit 6d8e2b2 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
maszlasz
changed the title
The aforementioned is utilized when preparing the signature algorithm list for the Certificate Request message in a TLS 1.3 handshake, which previously resulted in the list being erroneously reversed. Issue present since OTP 24.
maszlasz
force-pushed
the
msz/maint-24/ssl/fix-sign-alg-req-order
branch
from
f7b08e7 to
6d8e2b2
Compare
|
Hi, not sure if I should open this PR for a newer maint instead, is 24 too old to be updated? I see that the builds have failed due to some deprecations in actions. |
|
@maszlasz Preferably you should base your fix on a green version label from https://erlang.org/download/otp_versions_tree_app_vsns.html and then target you branch to maint. So if it is possible to make a clean merge for the fix based further back we can easily pig-back the fix onto patch releases for the still maintained versions at the moment that would include OTP-26 and OTP-27. If a clean merge is not possible we prefer a maint based patch and we would possible backport it ourselves if we consider it important to fix for older releases than the latest. We would also think it would be good with a test case. Although ssl has many test and I need to think a little where to best include such a test. I will get back to you on that. |
|
@maszlasz May be just changing |
|
@IngelaAndin Alright, thanks for letting me know. Then I'll be closing this PR and will open a new one based on 28 soon. @isvilen I tend to avoid foldr, but sure might as well, the list will always be small here. |
5 participants
Fixes #10694.