Handle __builtins__ both as dict and as module#54
Closed
singingwolfboy wants to merge 2 commits intoerikrose:masterfrom
Closed
Handle __builtins__ both as dict and as module#54singingwolfboy wants to merge 2 commits intoerikrose:masterfrom
singingwolfboy wants to merge 2 commits intoerikrose:masterfrom
Conversation
According to http://docs.python.org/2/reference/executionmodel.html: By default, when in the __main__ module, __builtins__ is the built-in module __builtin__ (note: no 's'); when in any other module, __builtins__ is an alias for the dictionary of the __builtin__ module itself. Therefore, this code needs to account for both cases.
There are probably many other contributors missing...
erikrose
added a commit
that referenced
this pull request
Mar 25, 2013
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to http://docs.python.org/2/reference/executionmodel.html:
Therefore, this code needs to account for both cases.