-
Notifications
You must be signed in to change notification settings - Fork 5
integration: add eth_simulateV1 tests #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8d8a79 to
bf9ab43
Compare
lupin012
approved these changes
Sep 26, 2025
canepat
added a commit
to erigontech/erigon
that referenced
this pull request
Sep 26, 2025
Implementation of `eth_simulateV1` as specified [here](https://ethereum.github.io/execution-apis/api-documentation/), there are also some additional notes [specifically for it](https://ethereum.github.io/execution-apis/ethsimulatev1-notes/). Closes #9881 *Additional Changes* - allow `nonce` override in `ethapi.ToMessage` - avoid chain ID derivation from `v` in `ethapi.NewRPCTransaction` for call simulation (i.e. where `v` is zero) - add `BlobGasUsed` field in `types.Receipt`and extract `core.MakeReceipt` to avoid duplicating the receipt creation - extend `jsonrpc.BlockOverrides` to cover more fields and fix JSON tags to match Geth's ones - define more RPC error codes *RPC Tests* - erigontech/rpc-tests#459 *Known Issues* - `stateRoot` mismatch in simulated blocks at latest state (4 tests are currently disabled for this reason)
NazariiDenha
pushed a commit
to erigontech/erigon
that referenced
this pull request
Oct 24, 2025
Implementation of `eth_simulateV1` as specified [here](https://ethereum.github.io/execution-apis/api-documentation/), there are also some additional notes [specifically for it](https://ethereum.github.io/execution-apis/ethsimulatev1-notes/). Closes #9881 *Additional Changes* - allow `nonce` override in `ethapi.ToMessage` - avoid chain ID derivation from `v` in `ethapi.NewRPCTransaction` for call simulation (i.e. where `v` is zero) - add `BlobGasUsed` field in `types.Receipt`and extract `core.MakeReceipt` to avoid duplicating the receipt creation - extend `jsonrpc.BlockOverrides` to cover more fields and fix JSON tags to match Geth's ones - define more RPC error codes *RPC Tests* - erigontech/rpc-tests#459 *Known Issues* - `stateRoot` mismatch in simulated blocks at latest state (4 tests are currently disabled for this reason)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.