[3.3] Turn on discovery v5 by default (#18578) #18639
Merged
+216
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns on discovery v5 by default. It adds `--discovery.v4` so you can also disable v4. It prefers to use disc v5 for node resolution. Most other changes are minimal changes from geth to maintain clean diff and updated behaviour around sources. I expect there will be some rough edges but the sooner v5 is active in main the sooner those will come up. Running with `--discovery.v4=false` might be worthwhile for testing, and maybe in some QA workflows.
anacrolix
requested review from
AskAlexSharov,
Giulio2002,
taratorio and
yperbasis
as code owners
AskAlexSharov
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables discv5 for 3.3 for #18195. Duplicates #18578 from main.
I think we want discv5 enabled in 3.3 if we want to meet the Jan 31 target. I wonder if we want to keep the resolution leaning toward discv4 for 3.3.